feat: Added submission history API and extended enrollment API to support grading and finished flags. - #31491
Conversation
|
Thanks for the pull request, @farhaanbukhsh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
Hi @farhaanbukhsh - is this ready for review? |
|
@mphilbrick211 This is going through internal review, :) once that is done I will ping you, hope that is okay. 😄 |
|
Hi @farhaanbukhsh! Just following up on the changes requested. |
Hi @mphilbrick211 thank you for checking up on the PR 😄 I am making those changes and should be up for another review soon. :) |
ecf386c to
bf496ce
Compare
|
@Agrendalath This PR is up for another review, I am still figuring out, why are the test not running and why is it throwing |
bf496ce to
0d9f1c9
Compare
mphilbrick211
added
the
waiting on author
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@farhaanbukhsh, there are still a few bugs, but it's looking much better.
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@farhaanbukhsh, thank you for your persistence! Please squash your commits into logical chunks before we merge.
👍
- I tested this: tested both APIs locally; checked that the pagination works correctly for the enrollments API
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
7a23d62 to
a0e3e19
Compare
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
…kdown. This feature helps to add submission history for each ProblemBlock in the course. It also adds API for section grades breakdown, that gives information about grades scored in each section of the course. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
a0e3e19 to
5e24f5d
Compare
|
@farhaanbukhsh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
5 participants
Description
These changes:
Enrollment API is enhanced to add grades for the course and the finished status for the course. We have also tried to fixthe pagination issue with the same.
Submission API is added to retrieve the submission history of the problem by a user. And course grade status end point help us to retrieve the information about course and how a
studentis doing in the course.Supporting information
BB-5591
open-craft@c8713a5
#18838
Testing instructions
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
TBD
Reviewer